Golnesa variable friction #346
Conversation
There was a problem hiding this comment.
I went trough the code line by line and left some comments. It looks good, some final touches for finishing it. Notably:
- Use pre-commit for static code analysis (linting)
- Preserve the call signatures of the tabulator functions (seperate out the insertion of the veg coefficients)
Please make sure the code works, confirm it by manually running it and optionally integrate it in the automated integration tests (you could for instance adjust the sqlite that is checked in into the repo)
| @@ -43,36 +49,47 @@ def convert(self, ids): | |||
| content_pk=ids, | |||
| code=self.code[idx], | |||
| count=0, | |||
| count_yz = 0, | |||
There was a problem hiding this comment.
Can you run the black code formatter? There's a pre-commit configuration in this repo, so after you installed the pre-commit tool (https://pre-commit.com/), you have to do pre-commit install inside the repository and then pre-commit run all
|
|
||
|
|
||
| def tabulate_yz(shape, width, height): | ||
| def tabulate_yz(shape, width, height, friction_values, vegetation_stem_densities, vegetation_stem_diameters, vegetation_heights, vegetation_drag_coefficients): |
There was a problem hiding this comment.
This call signature doesn't match the other call signatures (at line 68 you did adjust the altered return value, but the new parameters aren't provided)
I think it is good to leave the call signature as is and provide the additional vegentation coefs at a different moment.
GolnesaK
requested review from
daanvaningen
and removed request for
caspervdw
No description provided.